feat: validate observe-agent config instead of simply parsing the yaml #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-mattcotter
assigned
obs-gh-mattcotter and
obs-gh-alexlew and unassigned
obs-gh-mattcotter
| {{- if .Passed }} | ||
| Config file is valid YAML. |
There was a problem hiding this comment.
feels like if it errors for invalid yaml vs. erroring for failing validation those should be reflected separately in the template
| "strings" | ||
| ) | ||
|
|
||
| type HostMonitoringLogsConfig struct { |
There was a problem hiding this comment.
a lot of these I defined already in https://github.com/observeinc/observe-agent/blob/main/internal/commands/initconfig/configschema.go i like it being in config/configschema.go can you remove the definitions I have then and rework those references?
There was a problem hiding this comment.
I did that! internal/commands/initconfig/configschema.go is removed in this diff (not sure why git didn't register it as a move).
obs-gh-alexlew
approved these changes
Oct 25, 2024
obs-gh-mattcotter
force-pushed
the
OB-31850-diagnose-config-issues
branch
from
966ba0d to
a200f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-31850 Add validation of observe-agent config on top of simple YAML parsing.
Checklist