feat: remove some resource labels from prometheus metrics #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xueweiz
approved these changes
Mar 19, 2025
| - k8s.container.name | ||
| - container.id | ||
| labels: | ||
| - tag_name: app.kubernetes.io/name |
There was a problem hiding this comment.
WOW AWESOME, thanks for doing this!
obs-gh-mattcotter
approved these changes
Mar 19, 2025
| @@ -150,6 +136,28 @@ processors: | |||
| {{- include "config.processors.attributes.k8sattributes" . | nindent 2 }} | |||
|
|
|||
| {{- include "config.processors.resource.observe_common" . | nindent 2 }} | |||
| resource/drop_additional_pod_metrics_labels: | |||
There was a problem hiding this comment.
Are we reasonably confident that this won't break any downstream datasets customers could have created?
There was a problem hiding this comment.
There's no way to know really. These labels existed and after this they won't so if they are relying/filtering on them then that would break things. We could also draft this change as a major version change (and ideally roll it together with the removal of TRACE_TOKEN)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.