Skip to content

Conversation

@igorbej
Copy link
Contributor

@igorbej igorbej commented Feb 15, 2024

This PR fixes the issue where the type definitions are missing when installing the package from npm.

Co-authored-by: Tomas Echeverri <[email protected]>
"files": [
"src"
"src",
"*.d.ts"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add !*.d.ts to the .npmignore? @oblador

loki/.npmignore

Lines 1 to 6 in 2d833f0

*
!*.js
!bin/*
!src/**/*
src/**/*.spec.js
src/**/fixtures

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda weird to have both, I think that since the migration to a monorepo this file would be ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants