Issue with osnap when using pnpm

[pfongkye]

Hello, I recently upgraded to latest version of loki (0.28.1 -> 0.31.1) but I am having some issues when installing and running with pnpm:

> loki

(node:59566) UnhandledPromiseRejectionWarning: Error: Cannot find module '@ferocia-oss/osnap/src/ios'
Require stack:
- loki/examples/react/node_modules/.pnpm/@loki+target-native-ios-simulator@0.31.0/node_modules/@loki/target-native-ios-simulator/src/create-ios-simulator-target.js
...

The dependency is missing the src folder

When I ran with yarn, I don't have the same issue. I have the following

I think it is an issue with osnap but I could not file an issue on the GitHub project itself.

FYI, I'm using pnpm 7.30.0

Regards,
Pascal.

[davebrewer]

Also experience this issue, using npm rather than yarn and cannot work around with yarn as suggested as fix for this project.
Any other ideas for solution?

[pfongkye]

I don't know if it is because of these following lines in the package.json of osnap but it caught my attention:

  "np": {
    "yarn": true,
    "branch": "main"
  },

[trunneml]

Same problem here using yarn.

node:internal/modules/cjs/loader:995
  const err = new Error(message);
              ^

Error: Cannot find module '@ferocia-oss/osnap/src/ios'

[trunneml]

It looks like that the missing file is in osnap and not in @ferocia-oss/osnap

[levibuzolic]

This should be fixed by upgrading @ferocia-oss/osnap to 1.3.2

[kungfutse]

pinning the @ferocia-oss/osnap to version 1.3.2 causes es module error when running loki

> loki test --requireReference --reactUri='file:./dist-storybook'

/path/to/node_modules/@ferocia-oss/osnap/src/ios.js:45
var execa_1 = require("execa");
              ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /path/to/node_modules/@ferocia-oss/osnap/node_modules/execa/index.js from /path/to/node_modules/@ferocia-oss/osnap/src/ios.js not supported.
Instead change the require of index.js in /path/to/node_modules/@ferocia-oss/osnap/src/ios.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/path/to/node_modules/@ferocia-oss/osnap/src/ios.js:45:15)
    at Object.<anonymous> (/path/to/node_modules/@loki/target-native-ios-simulator/src/create-ios-simulator-target.js:3:15)
    at Object.<anonymous> (/path/to/node_modules/@loki/target-native-ios-simulator/src/index.js:1:34)
    at Object.<anonymous> (/path/to/node_modules/@loki/runner/src/commands/test/run-tests.js:16:5)
    at Object.<anonymous> (/path/to/node_modules/@loki/runner/src/commands/test/index.js:11:18)
    at getExecutorForCommand (/path/to/node_modules/@loki/runner/src/cli.js:21:14)
    at run (/path/to/node_modules/@loki/runner/src/cli.js:36:20)
    at Object.<anonymous> (/path/to/node_modules/@loki/runner/bin/loki:3:22) {
  code: 'ERR_REQUIRE_ESM'
}

[levibuzolic]

@kungfutse sorry about that, this should be now properly sorted in @ferocia-oss/osnap@1.3.5.

[pfongkye]

Hello, I tested it on my side and it seems to work now. Thank you all!