Allow tempo to decimal point #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatsu-gh
requested changes
Jun 9, 2023
Owner
oatsu-gh
left a comment
oatsu-gh
left a comment
There was a problem hiding this comment.
ありがとうございます。ただ、floatのかわりにDecimalに変換してほしいです。タイミング計算をするときに、末尾で丸め誤差が出てしまう場合があるためです。
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenUtauプロジェクトのIssueで、テンポが小数点まで入力されている場合、ラベル作成時にタイミングがずれる問題（stakira/OpenUtau#431 ）が出ていたので、丸め込まないように変更した。
Issue in the OpenUtau project (stakira/OpenUtau#431 ) where the timing was off when creating labels if tempo was entered to the decimal point, so it was changed to not rounding.