ESLint whole project + standardize ESLint config #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated error handling in various functions to omit the error parameter in catch blocks. - Changed type annotations from `any` to `unknown` in several interfaces and function parameters for better type safety. - Removed unnecessary parameters from functions, such as `filename` in `uploadRandomFileAndConfirm`. - Simplified locator functions by removing unused parameters. - Enhanced the `FormServiceInterface` and `I18nServiceInterface` to remove generic type parameters where not needed. - Adjusted the `uploadCompleteBar` locator to not require a filename. - Improved the handling of translations and localization by ensuring type safety in translation-related functions. - Updated tests to ensure they await asynchronous operations correctly and handle potential errors gracefully. - Cleaned up ESLint disable comments for better readability and maintainability.
…suppress unused variable warnings
…nd rule management + add jsdoc plugin
…for clarity and consistency with jsdoc ESLint plugin
mirekys
reviewed
Oct 7, 2025
mirekys
reviewed
Oct 7, 2025
mirekys
reviewed
Oct 7, 2025
mirekys
reviewed
Oct 7, 2025
tests/playwright.config.ts
Outdated
| { | ||
| apiToken: appConfig.qase.token, | ||
| projectCode: appConfig.qase.project, | ||
| apiToken: (appConfig.qase as any).token, |
Member
There was a problem hiding this comment.
Add alteast known basic typing for qase config?
Member
There was a problem hiding this comment.
mirekys
reviewed
Oct 7, 2025
| * Helper method to find the appropriate method name for a field. | ||
| */ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access */ | ||
| private getMethod(page: any, field: string, methodPrefixes: string[]): string { |
Member
There was a problem hiding this comment.
why disabling @typescript-eslint/no-explicit-any?
Contributor
Author
There was a problem hiding this comment.
Cause we don't know if the page is really of BasePage base type (or any type whatsover) if it doesn't have the appropriate methods we are looking for.
mirekys
reviewed
Oct 7, 2025
src/fixtures/index.ts
Outdated
| case 'describe': | ||
| // return a wrapper around the describe method that can skip tests | ||
| return (title: string, annotation?: any, callback?: () => void) => { | ||
| return (title: string, annotation?: unknown, callback?: () => void) => { |
Member
There was a problem hiding this comment.
annotation should have some typing
src/fixtures/index.ts
Outdated
| } | ||
| default: | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access | ||
| return (target as any)[prop]; |
Member
There was a problem hiding this comment.
Target type is known (extension of playwright base test
src/fixtures/index.ts
Outdated
| * will be marked as .skip. | ||
| */ | ||
| apply: (target, thisArg, args: any[]) => { | ||
| apply: (target, thisArg, args: unknown[]) => { |
src/fixtures/utils.ts
Outdated
|
|
||
| const page_creator = async (fixtures: any, use: UseFunction<L, T>) => { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const pageCreator = async (fixtures: any, use: UseFunction<L, T>) => { |
mirekys
requested changes
Oct 7, 2025
mirekys
reviewed
Oct 7, 2025
src/locators/index.ts
Outdated
| * ``` | ||
| * | ||
| * import { BasePage } from '@inveniosoftware/invenio-e2e'; | ||
| * class MyPage extends BasePage<MyLocators> { |
…tion; enhance README with dependency details
mirekys
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the ESLint configuration and refactor code to improve type safety and error handling across various functions. Adjustments include removing unnecessary parameters and updating type annotations.
NOTE: Prettify-cation will be done in next PR to not bloat this one with non-important changes.