Skip to content

refacto: add info builder pattern #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 11, 2023
Merged

refacto: add info builder pattern #1047

merged 4 commits into from
May 11, 2023

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented May 6, 2023 •
edited
Loading

As suggested here: #1034 (comment)

@o2sh o2sh changed the title Info builder pattern refacto: Info builder pattern May 6, 2023
@o2sh o2sh changed the title refacto: Info builder pattern refacto: add info builder pattern May 6, 2023
@o2sh o2sh requested a review from spenserblack May 6, 2023 14:59
spenserblack
spenserblack approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! It looks like this will make it a lot easier to test onefetch by granularly building an Info struct.

@o2sh o2sh merged commit 8609f92 into main May 11, 2023
@o2sh o2sh deleted the chore/builder-pattern branch May 11, 2023 17:11
@o2sh o2sh mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o2sh @spenserblack