Fix #703: if event eval has not changed, keep the current step + Update to hifitime 4.3.0, enabling Lunar Time and Lunar Coordinated Time#706
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the hifitime dependency to version 4.3.0 and refactors the step adjustment logic in anise/src/analysis/utils.rs to handle cases where the event evaluation remains constant, preventing division by zero. Feedback was provided regarding a typo in a comment and a potential overflow vulnerability when delta_ratio is extremely small, which could cause a panic in hifitime. A suggestion was made to bound delta_ratio to ensure the calculated step remains within the maximum allowed limit.
Member
Author
|
Added the first commit of #692 to this branch. |
This was referenced May 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #703: if event eval has not changed, keep the current step
Architectural Changes
No change
New Features
Improvements
No change
Bug Fixes
No change
Testing and validation
The
test_analysis_eventtest was triggering the bug, so I simply executed that with the (easy) fix.Documentation
This PR does not primarily deal with documentation changes.