Skip to content

Fix/294 metaload lock#305

Merged
ChristopherRabotin merged 4 commits into
masterfrom
fix/294-metaload-lock
Aug 23, 2024
Merged

Fix/294 metaload lock#305
ChristopherRabotin merged 4 commits into
masterfrom
fix/294-metaload-lock

Conversation

@ChristopherRabotin

Copy link
Copy Markdown
Member

Summary

  • Allow automatic deletion of the lock file after 10 tries, preventing a dead lock
  • Fix Lagrange CI tests for PRs of non-owners of the repo.

Architectural Changes

No change

New Features

No change

Improvements

Allow automatic deletion of the lock file after 10 tries, preventing a dead lock if the downloading was aborted.

Bug Fixes

No change

Testing and validation

None =(

Documentation

This PR does not primarily deal with documentation changes.

@ChristopherRabotin ChristopherRabotin merged commit b0f85f1 into master Aug 23, 2024
@ChristopherRabotin ChristopherRabotin deleted the fix/294-metaload-lock branch August 23, 2024 15:00
@gwbres

gwbres commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

It seems that anytime I'm using Almanac::latest (quickest and easiests) construction method, the cached Moon FK EPA is always discarded (CRC32 differs), download is then always needed and it regularly fails, so I re-run to pass.

Edit: well it fails on existing .lock file error, not network access error

@ChristopherRabotin

Copy link
Copy Markdown
Member Author

Even with the latest code merged you get a dead lock? I need to update the CRC because I think I forgot to update it when I built the file.

@gwbres

gwbres commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

Ah, my statement was based on the current stable, I should have been more accurate 😄

All my crates use the stable tags now, not branches. I may create a temporary branch for the zepto beta test, because it's huge and important, but it is also too much effort to reindex everything on different versions. I'm quite happy with the latest tags now, we can wait for newer ones

@ChristopherRabotin

Copy link
Copy Markdown
Member Author

Yes, I recommend that you use explicit versions and not branches at the moment. I hope that by the end of September I'll be able to have a stable release of hifitime and ANISE, and then make whatever changes are needed as smaller increments of these stable versions. I really need to get back to hifitime so that version 4 can finally be released, there's just a lot of Python work I have not done yet :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants