Update license to include Junegunn #148
Conversation
e82eric
changed the title
e82eric
force-pushed
the
include-junegun-in-license
branch
from
15a7d89 to
2e8e316
Compare
|
Makes sense, didnt know about that. Although does it need to be 2014-2024 if it was ported in 2021? Also can you add 2021-2025 next to my contribution? Unbelastet but did you change anything of my code to get Unicode working? Because we currently dont have Unicode support in regards to casing (ignore case), i did some work back in the day but havent finished that work |
e82eric
force-pushed
the
include-junegun-in-license
branch
from
2e8e316 to
c8ecf98
Compare
|
Just updated to include 2025. Based off of the comment from Microsoft and the stackoverflow post I think it needs 2014-2024 so it matches the fzf one but I am far from a lawyer. These were the changes I made for the unicode stuff, it uses ICU https://github.com/unicode-org/icu (basically swapping char* for UText and UChar) which is what windows terminal uses for searching unicode. From my testing it seemed to work for everything I could think of but I am far from a unicode expert. The only thing is that I didn't benchmark it, because windows terminal scroll back is 36k lines max so searches were instantaneous but I have a feeling it was a bit slower than your implementation. |
|
Okay thanks. Does that also means i have to update the license year if junegunn updates the year in his repository? |
|
I think only if you incorporate more changes from fzf after the years change in the fzf license. My understanding is you have to match the license at the time the work was derived from fzf. |
|
Then it would be 2021, but lets keep it like that. Thanks |
|
np, thank you! I am a huge fan of this project. |
#18700) It's the fzf algorithm! Repurposed work from #16586 - I think the fzf algo fits here where it optimizes to find the optimal match based on consecutive chars and word boundaries. - There are some edge cases where a match with a small gap could get a higher score than a match of consecutive chars when the match with a gap has other bonuses (FirstChar * Boundary Bonus). This can be adjusted by adjusting the bonuses or removing them if needed. - From reading the thread in #6693 it looked like you guys were leaning towards something like the fzf algo. - License file is now updated in https://github.com/nvim-telescope/telescope-fzf-native.nvim repository - nvim-telescope/telescope-fzf-native.nvim#148 - junegunn/fzf#4310 - Removed the following from the original implementation to minimize complexity and the size of the PR. (Let me know if any of these should be added back). - Query expressions "$:StartsWith ^:EndsWith |:Or !:Not etc" - Slab to avoid allocating the scoring matrix. This felt like overkill for the number of items in the command pallete. - Fallback to V1 algorithm for very long strings. I want to say that the command palette won't have strings this long. - Added the logic from GH#9941 that copies pattern and text chars to string for comparision with lstrcmpi - It does this twice now which isn't great... Closes #6693 --------- Co-authored-by: Leonard Hecker <[email protected]>
2 participants
Hi, I had created a pull request to Windows Terminal to add a fuzzy finder that used this library and they had done some research and found that it couldn't be brought in because it did not include the original copyright text from the fzf license.
microsoft/terminal#16586 (comment)
https://softwareengineering.stackexchange.com/a/386584
I don't think my pull request will be merged but I figured it would be worth checking to see if the license could be added in case anyone else runs into this.
The pr adds Copyright (c) 2013-2024 Junegunn Choi, and then a couple of other words in the boilerplate did not match the fzf one. I don't know how important those lines are but from what I could tell it was better to try to match the original license.