Update pyright to use [nodejs] #19078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17749
Summary of the issue:
#17744 introduced pyright using it's default server nodeenv.
The pyright python package recommends installing pyright[nodejs] for a faster and more reliable server.
Hwever we couldn't use it while NVDA was 32bit.
This is because the node wheel binaries required a 64bit environment.
Now that NVDA has migrated to 64bit, we should update the pyright package version to using nodejs.
Description of user facing changes:
None
Description of developer facing changes:
update pyright
Description of development approach:
update pyright
Testing strategy:
CI/CD
Known issues with pull request:
Pre-commit CI for pyright is broken: RobertCraigie/pyright-python#345
So some of the benefits discussed in #17748 no longer apply
Code Review Checklist: