Skip to content

Conversation

@seanbudd
Copy link
Member

@seanbudd seanbudd commented Oct 10, 2025

Link to issue number:

Closes #17749

Summary of the issue:

#17744 introduced pyright using it's default server nodeenv.
The pyright python package recommends installing pyright[nodejs] for a faster and more reliable server.
Hwever we couldn't use it while NVDA was 32bit.
This is because the node wheel binaries required a 64bit environment.
Now that NVDA has migrated to 64bit, we should update the pyright package version to using nodejs.

Description of user facing changes:

None

Description of developer facing changes:

update pyright

Description of development approach:

update pyright

Testing strategy:

CI/CD

Known issues with pull request:

Pre-commit CI for pyright is broken: RobertCraigie/pyright-python#345
So some of the benefits discussed in #17748 no longer apply

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested review from Copilot and removed request for Copilot October 10, 2025 03:17
@seanbudd seanbudd requested a review from a team as a code owner October 10, 2025 03:17
@seanbudd seanbudd requested a review from SaschaCowley October 10, 2025 03:17
@seanbudd seanbudd mentioned this pull request Oct 10, 2025
15 tasks
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 14, 2025
Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @seanbudd

Copilot AI review requested due to automatic review settings October 14, 2025 06:01
@seanbudd seanbudd enabled auto-merge (squash) October 14, 2025 06:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the type checker tooling to use the Node.js-backed Pyright for improved reliability and performance and bumps the version accordingly.

  • Switch dev lint dependency to pyright[nodejs]==1.1.406
  • Update pre-commit hook to v1.1.406
  • Update developer changelog entry

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
user_docs/en/changes.md Add changelog entry for the Pyright update
pyproject.toml Replace pyright with pyright[nodejs] and bump to 1.1.406 in dev lint dependencies
.pre-commit-config.yaml Bump pyright pre-commit hook to v1.1.406

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@seanbudd seanbudd merged commit 2d6aff1 into master Oct 14, 2025
29 checks passed
@seanbudd seanbudd deleted the update-pyright branch October 14, 2025 06:49
@github-actions github-actions bot added this to the 2026.1 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update pyright to use pyright[nodejs] locally

3 participants