Skip to content

NLS eReader Zoomax braille driver #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

florin-trutiu
Copy link

@florin-trutiu florin-trutiu commented Jun 16, 2025

Link to issue number:

#15863

Summary of the issue:

This is the NVDA driver for the NLS eReader Zoomax braille display.
It supports both USB and Bluetooth automatic detection.

Description of user facing changes:

With this driver the user can use directly the NLS eReader Zoomax display without the need to manually install it as an addon.

Description of developer facing changes:

Description of development approach:

The driver is similar with the existing braille display drivers for NVDA.

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@florin-trutiu florin-trutiu requested review from a team as code owners June 16, 2025 09:25
@LeonarddeR
Copy link
Collaborator

@florin-trutiu Make sure to fill in the pull request template by editing pull request description. There's also something wrong with the changes file, resulting into a huge amount of unrelated changes.

@florin-trutiu
Copy link
Author

florin-trutiu commented Jun 16, 2025

@florin-trutiu Make sure to fill in the pull request template by editing pull request description. There's also something wrong with the changes file, resulting into a huge amount of unrelated changes.

@LeonarddeR
Hi, I'm sorry, please help me, I do not know how to proceed.
I already have a pull request #17509 in which I filled the template.
The problem was that I was requested a few more changes which I only completed now (a few months later) and there it said I was a lot of commits behind.
Now in the old pull request I have no changes, and all my changes and discussions appear here.

@AppVeyorBot
Copy link

See test results for failed build of commit cfd67c5126

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jun 16, 2025
@seanbudd seanbudd requested a review from SaschaCowley June 17, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants