handle cases where '_dl' directory fails to delete in addon store init #19202
Description
Related issues, PRs or discussions
Follow-on from #19133
What is the current state of the codebase?
We don't currently have any try/except logic around the deletion of _dl. This can cause NVDA to crash, and I don't know why, but this ends in a full crash, not just a error in the log.
Why are changes required?
We should catch exceptions and log them, rather than crashing NVDA. addon store is non-critical and we can continue with life if it's broken.
What technical changes are required?
A try/except around some code in the addon gui's viewmodel initialization. I'll be sending a PR soon for this.
Are the proposed technical changes API breaking?
No
Are there potential risks or issues with the proposed implementation?
No, this is simply a missed error handling case that ended up manifesting in a far more violent way than I would anticipate, so I'm going to fix it in case some other user tries to back up their NVDA settings dir with google drive's directory backup feature like I did.