Fix: examples build on aarch64 #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a linker error on aarch64 indicating that `-lmorpheus` could not be found.
Two possible solutions existed:
1. change the LINK_TARGETS from `morpheus` to `morpheus::morpheus`
2. add `find_library` calls to find the morpheus shared library on the system.
(1) unfortunately resulted in a public link failing of mrc::pymrc -- which probably
indicates that we shouldn't be exposing that as a public link dependency.
(2) was chosen because it's what we'd expect the system to do -- find the installed
morpheus shared object file and link to it.
It's a bit cumbersome but it works as intended. This is more of a hotfix/patch
rather than a complete engineered solution. Improvements and enhancements are welcome.
Signed-off-by: Will Killian <[email protected]>
Signed-off-by: Will Killian <[email protected]>
github-project-automation
bot
moved this from Review - Ready for Review
to Review - Approved
in Morpheus Boards
Contributor
|
/merge |
rapids-bot
bot
merged commit 6e498f5
into
nv-morpheus:branch-25.06
13 of 14 checks passed
github-project-automation
bot
moved this from Review - Approved
to Done
in Morpheus Boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a linker error on aarch64 indicating that
-lmorpheuscould not be found.Two possible solutions existed:
morpheustomorpheus::morpheusfind_librarycalls to find the morpheus shared library on the system.(1) unfortunately resulted in a public link failing of mrc::pymrc -- which probably indicates that we shouldn't be exposing that as a public link dependency.
(2) was chosen because it's what we'd expect the system to do -- find the installed morpheus shared object file and link to it.
It's a bit cumbersome but it works as intended. This is more of a hotfix/patch rather than a complete engineered solution. Improvements and enhancements are welcome.
Description
Closes
By Submitting this PR I confirm: