Skip to content

Fix conda package dependency issues #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagardner-nv wants to merge 27 commits into from
Closed

Fix conda package dependency issues #2220

dagardner-nv wants to merge 27 commits into from

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 2, 2025 •
edited
Loading

Description

Closes #2066

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Fix out of date docker-py deps
b367cb0 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv self-assigned this Jun 2, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner June 2, 2025 18:42
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change conda-build Enables running the conda-build step on a PR labels Jun 2, 2025
@morpheus-bot-test morpheus-bot-test bot moved this to Review - Ready for Review in Morpheus Boards Jun 2, 2025
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Review - Approved in Morpheus Boards Jun 2, 2025
@dagardner-nv
Work-around for nv-morpheus#2219
1806914 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv requested a review from a team as a code owner June 2, 2025 19:32
@morpheus-bot-test morpheus-bot-test bot moved this from Review - Approved to Review - Ready for Review in Morpheus Boards Jun 2, 2025
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Review - Approved in Morpheus Boards Jun 4, 2025
dagardner-nv added 12 commits June 4, 2025 11:31
@dagardner-nv
I don't know
7074b35 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Try just libgcc by itself
d3c6be4 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Try just libgcc by itself
992b989 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Move libgcc to host section
b779847 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Pin libgcc to a range
10138ef 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Narrow the range
4ea5e93 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Adopt new mlflow and fix test
47c3cc1 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Remove mlflow pin, remove libgcc dep
52d7e62 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
WIP
ee5e628 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Update base container to match what CI is doing:
3f45e4a 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Add a comment explaining why mlflow is in the host section
6ce1ee9 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Update mlflow dep to match the other envs
5df1ac6 
Signed-off-by: David Gardner <[email protected]>
willkill07
willkill07 approved these changes Jun 6, 2025
View reviewed changes
@dagardner-nv dagardner-nv changed the title Fix out of date docker-py deps Fix conda package dependency issues Jun 6, 2025
dagardner-nv and others added 2 commits June 6, 2025 12:33
@dagardner-nv @willkill07
Apply suggestions from code review
665f4d7 
Co-authored-by: Will Killian <[email protected]>
@willkill07
Test: pin cuda-python
e05dfe0 
Signed-off-by: Will Killian <[email protected]>
@dagardner-nv dagardner-nv mentioned this pull request Jun 9, 2025
Closed
2 tasks
@willkill07
Version pytorch based on host architecture
47f5228 
Signed-off-by: Will Killian <[email protected]>
@willkill07
WIP
adb2ce5 
Signed-off-by: Will Killian <[email protected]>
@dagardner-nv
Copy link
Contributor Author

dagardner-nv commented Jun 10, 2025

Closing in favor of #2229

@github-project-automation github-project-automation bot moved this from Review - Approved to Done in Morpheus Boards Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

bug Something isn't working conda-build Enables running the conda-build step on a PR non-breaking Non-breaking change

Projects

Morpheus Boards
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA]: Update tests/morpheus/test_cli.py to work with mlflow 2.18+

2 participants

@dagardner-nv @willkill07