Adopt Rapids 25.02 and CUDA 12.8 #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpheus into david-25.02-x-25.02
…mount for apt, pip and conda
dagardner-nv
added
dependencies
Contributor
Author
|
/ok to test |
Cleanup DOCA env vars Remove redundant calls to `apt update`, remove call to `apt upgrade`. Fix download location for `doca-host.deb` Consolidate installing of doca packagwes
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
dagardner-nv
changed the title
Contributor
Author
|
/ok to test |
Merged
mdemoret-nv
approved these changes
Feb 19, 2025
Contributor
mdemoret-nv
left a comment
mdemoret-nv
left a comment
There was a problem hiding this comment.
Looked over the source code changes but a deeper look at CI/Dockerfiles should be done
willkill07
approved these changes
Feb 19, 2025
Member
willkill07
left a comment
willkill07
left a comment
There was a problem hiding this comment.
The added notes for DOCA are nice -- hopefully reduces future hair-pulling.
Overall, everything here LGTM 👍
Contributor
Author
|
/merge |
willkill07
pushed a commit
to dagardner-nv/Morpheus
that referenced
this pull request
Feb 21, 2025
* When building with DOCA in CI restrict the `MORPHEUS_CUDA_ARCHITECTURES` to just those supported by DOCA. * Install DOCA from an apt repository rather than downloading a deb file * Avoid a version conflict for the `mft` package by manually specifying the version of `mft` to ensure the package is installed from the DOCA repo and not the CUDA repo. * Incorporates changes from nv-morpheus#2097 to `cudf_helpers.pyx` to match changes made to cudf. Closes nv-morpheus#2182 - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - Will Killian (https://github.com/willkill07) URL: nv-morpheus#2183
dagardner-nv
added a commit
that referenced
this pull request
Mar 20, 2025
* When building with DOCA in CI restrict the `MORPHEUS_CUDA_ARCHITECTURES` to just those supported by DOCA. * Install DOCA from an apt repository rather than downloading a deb file * Avoid a version conflict for the `mft` package by manually specifying the version of `mft` to ensure the package is installed from the DOCA repo and not the CUDA repo. * Incorporates changes from #2097 to `cudf_helpers.pyx` to match changes made to cudf. Closes #2182 - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - Will Killian (https://github.com/willkill07) URL: #2183 Signed-off-by: David Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MORPHEUS_CUDA_ARCHITECTURESto just those supported by DOCA.mftpackage by manually specifying the version ofmftto ensure the package is installed from the DOCA repo and not the CUDA repo.cudf_helpers.pyxto match changes made to cudf.Closes #2182
By Submitting this PR I confirm: