Several fixes & improvements of C++ MonitorStage
#2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ok to test |
…com:yczhang-nv/Morpheus into yuchen-fix-monitor-stage-one-log-line-issue
Contributor
Author
|
/ok to test |
willkill07
reviewed
Feb 5, 2025
Member
willkill07
left a comment
willkill07
left a comment
There was a problem hiding this comment.
Just some minor feedback + suggestions. Nothing that should block the PR.
python/morpheus/morpheus/_lib/include/morpheus/controllers/monitor_controller.hpp
Outdated
Show resolved
Hide resolved
python/morpheus/morpheus/_lib/include/morpheus/controllers/monitor_controller.hpp
Show resolved
Hide resolved
…monitor-stage-one-log-line-issue
Contributor
Author
|
/ok to test |
…itor_controller.hpp Co-authored-by: Will Killian <[email protected]>
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
willkill07
approved these changes
Feb 6, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MonitorStagenow ensures there's at least one line of progress bar output with throughput shown.Ctrl+C,MonitorStagenow ensures to output the progress bars again when the pipeline is completed, avoids the progress bars from being covered by other logs.microsecondswhen calculating the throughput to avoidinfthroughput[Completed]Closes #2148
By Submitting this PR I confirm: