-
Notifications
You must be signed in to change notification settings - Fork 0
Move attention transforms to new inference optimizer #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: haoguo <[email protected]>
91145ec
to
aa94e2e
Compare
Signed-off-by: haoguo <[email protected]>
Signed-off-by: haoguo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Please also check in @Fridah-nv and get her approval on the PR
# TODO (hg): default values that are not representable in YAML. | ||
if "match_attention_layout" in self.ad_config.transforms: | ||
self.ad_config.transforms[ | ||
"match_attention_layout" | ||
].attention_op = AttentionRegistry.get(self.ad_config.attn_backend) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was worried we were going to eventually hit a scenario like this where a config value is shared across multiple transforms...
Let's leave it like this for now to avoid blowing up the PR. But feel free to propose a few ideas about what we can do in order to "share" config values across multiple transforms and we can discuss on slack / during our 1-on-1
Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]>
Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]>
Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]>
Signed-off-by: haoguo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Signed-off-by: haoguo <[email protected]>
* refactor: merge attn updates;move to new inf optimizer Signed-off-by: haoguo <[email protected]> * minor: fix import Signed-off-by: haoguo <[email protected]> * doc: fix file docstring Signed-off-by: haoguo <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * polish: use config.run_shape_prop for shape prop Signed-off-by: haoguo <[email protected]> * polish: remove redundant canonicalize() Signed-off-by: haoguo <[email protected]> --------- Signed-off-by: haoguo <[email protected]> Signed-off-by: h-guo18 <[email protected]> Co-authored-by: Lucas Liebenwein <[email protected]>
* refactor: merge attn updates;move to new inf optimizer Signed-off-by: haoguo <[email protected]> * minor: fix import Signed-off-by: haoguo <[email protected]> * doc: fix file docstring Signed-off-by: haoguo <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * polish: use config.run_shape_prop for shape prop Signed-off-by: haoguo <[email protected]> * polish: remove redundant canonicalize() Signed-off-by: haoguo <[email protected]> --------- Signed-off-by: haoguo <[email protected]> Signed-off-by: h-guo18 <[email protected]> Co-authored-by: Lucas Liebenwein <[email protected]>
* refactor: merge attn updates;move to new inf optimizer Signed-off-by: haoguo <[email protected]> * minor: fix import Signed-off-by: haoguo <[email protected]> * doc: fix file docstring Signed-off-by: haoguo <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py Co-authored-by: Lucas Liebenwein <[email protected]> Signed-off-by: h-guo18 <[email protected]> * polish: use config.run_shape_prop for shape prop Signed-off-by: haoguo <[email protected]> * polish: remove redundant canonicalize() Signed-off-by: haoguo <[email protected]> --------- Signed-off-by: haoguo <[email protected]> Signed-off-by: h-guo18 <[email protected]> Co-authored-by: Lucas Liebenwein <[email protected]>
@coderabbitai summary
Description
#98
Test Coverage
with modification, tp=1:
target branch, tp1=:
with modification, tp=2:
target branch, tp=2:
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]
Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id
(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test
(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"
(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log
(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug
(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list
parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md
and the
scripts/test_to_stage_mapping.py
helper.kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.