Skip to content

Conversation

h-guo18
Copy link

@h-guo18 h-guo18 commented Jul 24, 2025

@coderabbitai summary

Description

#98

Test Coverage

  • Unite tests passed;
  • Trt-bench:
    with modification, tp=1:
Request Throughput (req/sec):                     39.0233
Total Output Throughput (tokens/sec):             4994.9836
Total Token Throughput (tokens/sec):              9989.9672
Total Latency (ms):                               25625.7099
Average request latency (ms):                     19997.5614
Per User Output Throughput [w/ ctx] (tps/user):   6.9144
Per GPU Output Throughput (tps/gpu):              4994.9836

target branch, tp1=:

Request Throughput (req/sec):                     38.3011
Total Output Throughput (tokens/sec):             4902.5367
Total Token Throughput (tokens/sec):              9805.0735
Total Latency (ms):                               26108.9324
Average request latency (ms):                     20536.3980
Per User Output Throughput [w/ ctx] (tps/user):   6.6992
Per GPU Output Throughput (tps/gpu):              4902.5367

with modification, tp=2:

Request Throughput (req/sec):                     26.5951
Total Output Throughput (tokens/sec):             3404.1689
Total Token Throughput (tokens/sec):              6808.3378
Total Latency (ms):                               37600.9547
Average request latency (ms):                     29403.6189
Per User Output Throughput [w/ ctx] (tps/user):   4.7042
Per GPU Output Throughput (tps/gpu):              1702.0844

target branch, tp=2:

Request Throughput (req/sec):                     26.2887
Total Output Throughput (tokens/sec):             3364.9543
Total Token Throughput (tokens/sec):              6729.9085
Total Latency (ms):                               38039.1502
Average request latency (ms):                     29636.2802
Per User Output Throughput [w/ ctx] (tps/user):   4.6821
Per GPU Output Throughput (tps/gpu):              1682.4771

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@h-guo18 h-guo18 self-assigned this Jul 24, 2025
@h-guo18 h-guo18 requested a review from lucaslie July 24, 2025 06:52
@h-guo18 h-guo18 marked this pull request as ready for review July 24, 2025 06:52
@lucaslie
Copy link
Collaborator

We will have to wait for #101 to land and then update this PR accordingly #101 is a pretty heavy rewrite of the attention transform

@h-guo18 h-guo18 force-pushed the haoguo/move_attn_transforms branch from 91145ec to aa94e2e Compare July 31, 2025 01:45
h-guo18 added 2 commits July 31, 2025 02:15
Copy link
Collaborator

@lucaslie lucaslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Please also check in @Fridah-nv and get her approval on the PR

Comment on lines +59 to +63
# TODO (hg): default values that are not representable in YAML.
if "match_attention_layout" in self.ad_config.transforms:
self.ad_config.transforms[
"match_attention_layout"
].attention_op = AttentionRegistry.get(self.ad_config.attn_backend)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried we were going to eventually hit a scenario like this where a config value is shared across multiple transforms...

Let's leave it like this for now to avoid blowing up the PR. But feel free to propose a few ideas about what we can do in order to "share" config values across multiple transforms and we can discuss on slack / during our 1-on-1

@h-guo18 h-guo18 requested a review from Fridah-nv July 31, 2025 04:20
Copy link

@Fridah-nv Fridah-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@h-guo18 h-guo18 merged commit f6834b1 into feat/ad-2025-07-22 Jul 31, 2025
1 check passed
@h-guo18 h-guo18 deleted the haoguo/move_attn_transforms branch July 31, 2025 05:47
lucaslie added a commit that referenced this pull request Jul 31, 2025
* refactor: merge attn updates;move to new inf optimizer

Signed-off-by: haoguo <[email protected]>

* minor: fix import

Signed-off-by: haoguo <[email protected]>

* doc: fix file docstring

Signed-off-by: haoguo <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* polish: use config.run_shape_prop for shape prop

Signed-off-by: haoguo <[email protected]>

* polish: remove redundant canonicalize()

Signed-off-by: haoguo <[email protected]>

---------

Signed-off-by: haoguo <[email protected]>
Signed-off-by: h-guo18 <[email protected]>
Co-authored-by: Lucas Liebenwein <[email protected]>
Fridah-nv pushed a commit that referenced this pull request Jul 31, 2025
* refactor: merge attn updates;move to new inf optimizer

Signed-off-by: haoguo <[email protected]>

* minor: fix import

Signed-off-by: haoguo <[email protected]>

* doc: fix file docstring

Signed-off-by: haoguo <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* polish: use config.run_shape_prop for shape prop

Signed-off-by: haoguo <[email protected]>

* polish: remove redundant canonicalize()

Signed-off-by: haoguo <[email protected]>

---------

Signed-off-by: haoguo <[email protected]>
Signed-off-by: h-guo18 <[email protected]>
Co-authored-by: Lucas Liebenwein <[email protected]>
Fridah-nv pushed a commit that referenced this pull request Jul 31, 2025
* refactor: merge attn updates;move to new inf optimizer

Signed-off-by: haoguo <[email protected]>

* minor: fix import

Signed-off-by: haoguo <[email protected]>

* doc: fix file docstring

Signed-off-by: haoguo <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* Update tensorrt_llm/_torch/auto_deploy/transform/library/attention.py

Co-authored-by: Lucas Liebenwein <[email protected]>
Signed-off-by: h-guo18 <[email protected]>

* polish: use config.run_shape_prop for shape prop

Signed-off-by: haoguo <[email protected]>

* polish: remove redundant canonicalize()

Signed-off-by: haoguo <[email protected]>

---------

Signed-off-by: haoguo <[email protected]>
Signed-off-by: h-guo18 <[email protected]>
Co-authored-by: Lucas Liebenwein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants