fix: resolve #og-image alias when no subpath is given (#615)#617
Merged
Conversation
`fixSharedPath` only rewrote `/shared/runtime/` with a trailing slash,
so `resolve('./runtime')` produced `dist/shared/runtime` (no trailing
slash) and the rewrite never fired. The `#og-image` alias then pointed
at a path that doesn't exist in the published `dist/`.
Match either a trailing slash or end-of-string so bare paths are
rewritten too.
commit: |
Collaborator
Author
|
Verified end-to-end against a consumer using the built dist:
No virtual type declaration is needed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #615
❓ Type of change
📚 Description
fixSharedPathonly rewrote/shared/runtime/when followed by a trailing slash, so the bare alias registrationresolve('./runtime')slipped through asdist/shared/runtime(which does not exist in the published bundle). Switched the matcher to a regex that also accepts end-of-string, so the#og-imagealias now resolves todist/runtimewhether or not a subpath is appended.