Skip to content

Conversation

as-yakovenko
Copy link
Contributor

@as-yakovenko as-yakovenko commented Jun 15, 2025

  • Documented user facing changes
  • Added or updated tests (not applicable for this change)
  • Updated CHANGELOG.md

Changes

Added a public path() getter method to the ASTCache class to improve API consistency and make the class easier to extend. The method returns the current schema cache file path and allows clean external access to override the cache path without relying on direct property access.

This change:

  • Exposes the internal $path property via a consistent public API
  • Improves extensibility for use cases with dynamic schema caching (e.g. multi-tenant or per-request schemas)
  • Aligns with object-oriented encapsulation best practices

Breaking changes

None. This is a fully backward-compatible addition that does not affect existing behavior or usage.

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@spawnia spawnia added the enhancement A feature or improvement label Jun 16, 2025
@as-yakovenko as-yakovenko requested a review from spawnia June 16, 2025 10:58
@spawnia spawnia merged commit 0276c54 into nuwave:master Jun 17, 2025
62 checks passed
@spawnia
Copy link
Collaborator

spawnia commented Jun 17, 2025

Thank you. Released with https://github.com/nuwave/lighthouse/releases/tag/v6.59.0. Please consider sponsoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants