Skip to content
This repository was archived by the owner on Mar 29, 2020. It is now read-only.

RelayConnectionType injectCursor compatibility with Laravel 5.2 #22

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

kutagh
Copy link

@kutagh kutagh commented Jun 3, 2016

As per the Laravel 5.2 upgrade guide:

Key Preservation

The slice, chunk, and reverse methods now preserve keys on the collection. If you do not want these methods to preserve keys, use the values method on the Collection instance.

RelayConnectionType->injectCursor($collection) was broken in Laravel 5.2, not generating a properly sequenced cursor when using pagination.

@chrissm79 chrissm79 merged commit 1cf05d3 into nuwave:master Jun 3, 2016
@chrissm79
Copy link
Contributor

Looks good, thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants