Skip to content

(#27) Modified XGetMainDisplay to default to $DISPLAY instead of ':0.0' #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2021
Merged

(#27) Modified XGetMainDisplay to default to $DISPLAY instead of ':0.0' #28

merged 1 commit into from
Jan 23, 2021

Conversation

s1hofmann
Copy link
Member

@s1hofmann s1hofmann commented Sep 4, 2020 •
edited
Loading

This PR closes #27

@s1hofmann s1hofmann added the enhancement New feature or request label Sep 4, 2020
@s1hofmann s1hofmann changed the title (#27) Modified XGetMainDisplay to default $DISPLAY to instead of ':0.0' (#27) Modified XGetMainDisplay to default to $DISPLAY instead of ':0.0' Sep 5, 2020
@s1hofmann s1hofmann requested a review from svettwer September 9, 2020 15:53
@s1hofmann
Copy link
Member Author

@svettwer Do you think you’ll find time to review this PR?

@svettwer
Copy link
Contributor

svettwer commented Dec 2, 2020

I have it on my list. 😁📃
I'll try to get it done soon.

@svettwer
Copy link
Contributor

svettwer commented Dec 4, 2020 •
edited
Loading

Changed as specified in the reference 👍
One enhancement could be to improve getXDisplay by resolving the DISPLAY environment variable as return value to follow the POSIX specification in case display_name is null (which is always the case currently). Or does getXDisplay overwrite the display_name variable as a side effect if it was initially set to NULL?

@s1hofmann s1hofmann merged commit 2731045 into develop Jan 23, 2021
@s1hofmann s1hofmann deleted the feature/27/xgetmaindisplay branch January 23, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svettwer svettwer svettwer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux: Update XGetMainDisplay to avoid receiving Invalid MIT-MAGIC-COOKIE-1 key
2 participants
@s1hofmann @svettwer