-
-
Notifications
You must be signed in to change notification settings - Fork 170
MAINT: Update Circle and conf.py #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage ? 87.85%
=======================================
Files ? 7
Lines ? 1334
Branches ? 320
=======================================
Hits ? 1172
Misses ? 104
Partials ? 58 |
On latest And this preserves the navbar search and icons, but with out the deprecation warning: And the bugs mentioned in #318 are fixed: And #310 looks to be correct, no need to escape as seen in the new tinybuild artifacts: This looks pretty straightforward so I'll merge this tomorrow and then merge #310 unless folks have comments. |
I see Codecov is back with a new bot:( Banned from the SciPy GitHub org now. EDIT: misread repo, also banned from the NumPy org now. |
I had to search for what it was, still not sure. Here's the separate artifact: https://285-11639513-gh.circle-artifacts.com/0/tinybuild/index.html. What does this show that the regular doc build doesn't? |
Basically https://github.com/numpy/numpydoc/blob/main/numpydoc/tests/test_full.py#L14-L16 I think it'll be useful check the output visually when changes are made to our code in addition to being able to check it programmatically, which is what we currently do in It only adds 2s (1s for build, 1s for upload of artifacts) to the CircleCI build so it's negligible in terms of added time.
In this case what it has that the main build does not is a |
Ahh I guess somehow https://285-11639513-gh.circle-artifacts.com/0/html/example.html Nonetheless I think it'll be useful to see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation Eric, makes sense. In it goes.
main
CircleCI build where we used a deprecated way of putting the search in the navbar:https://app.circleci.com/pipelines/github/numpy/numpydoc/287/workflows/e91a2751-3810-4e37-9ccb-f8f4e419ceb1/jobs/283
tinybuild
to the CircleCI build. I wanted to look at the output so that I could see if the*args, **kwargs
that show up in the API docs there render properly so that we can merge Be explicit about leading * when documenting *args, **kwargs. #310.Closes #318