Skip to content

[FIX] Hide non-API symbols when CXX compiler supports GNUC style visibility controls to prevent LLVM symbol export and interposition #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esc merged 7 commits into from
Oct 8, 2025
Merged

[FIX] Hide non-API symbols when CXX compiler supports GNUC style visibility controls to prevent LLVM symbol export and interposition #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f0ab8b
ffi/CMakeL*.txt: check support of GNUC vis ctrls
domcharrier Oct 1, 2025
bca4f36
ffi/core.h: __attribute__(...) to API_EXPORT macro
domcharrier Oct 1, 2025
3fefe98
Revert "ffi/core.h: __attribute__(...) to API_EXPORT macro"
domcharrier Oct 2, 2025
f641fb2
Revert "ffi/CMakeL*.txt: check support of GNUC vis ctrls"
domcharrier Oct 2, 2025
d352fa5
ffi/CMakeLists.txt: preset func vis to hidden
domcharrier Oct 2, 2025
c8c525b
ffi/core.h: make API functions visible (non-MSC)
domcharrier Oct 2, 2025
b9994b8
ffi/CMakeLists.txt: static LLVM link w -Bsymbolic
domcharrier Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ffi/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ include(GNUInstallDirs)

set(CMAKE_CXX_STANDARD 17)

# Preset function visibility to hidden, API functions
# are annotated explicitly to use 'default' visibility.
set(CMAKE_CXX_VISIBILITY_PRESET "hidden")
set(CMAKE_C_VISIBILITY_PRESET "hidden")

find_package(LLVM REQUIRED CONFIG)

message(STATUS "Found LLVM ${LLVM_PACKAGE_VERSION}")
Expand Down Expand Up @@ -316,7 +321,6 @@ endif()
message(STATUS "LLVM target link libraries: ${llvm_libs}")
target_link_libraries(llvmlite ${llvm_libs})


# -flto and --exclude-libs allow removal of unused parts of LLVM
# TODO: these options are just set, they should really be tested for
# suitability.
Expand All @@ -328,6 +332,12 @@ if(UNIX AND NOT APPLE)
if (LLVMLITE_FLTO)
STRING(APPEND FORCED_LINK_FLAGS " -flto")
endif()
if(NOT LLVMLITE_SHARED)
# If LLVM is statically linked, we specify -Bsymbolic to prevent
# that LLVM symbols can be interposed upon by previously
# loaded shared objects that export LLVM symbols.
STRING(APPEND FORCED_LINK_FLAGS " -Wl,-Bsymbolic")
endif()
set_property(TARGET llvmlite APPEND_STRING PROPERTY LINK_FLAGS
"${FORCED_LINK_FLAGS}")
elseif(APPLE)
Expand Down
3 changes: 2 additions & 1 deletion ffi/core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
#if defined(HAVE_DECLSPEC_DLL)
#define API_EXPORT(RTYPE) __declspec(dllexport) RTYPE
#else
#define API_EXPORT(RTYPE) RTYPE
// Non-windows: use visibility attributes.
#define API_EXPORT(RTYPE) __attribute__((visibility("default"))) RTYPE
#endif

extern "C" {
Expand Down