Fix Windows llvmdev build due to zlib linkage #1108
Conversation
and add GHA for building windows llvmdev for wheels Main difference in recipe is disabling zlib and zstd since they are not available on official CPython installation.
| @@ -0,0 +1,51 @@ | |||
| name: llvmdev_win_builder | |||
There was a problem hiding this comment.
This is a adaptation of https://github.com/numba/llvmlite/pull/1106/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR162-R207
This workflow is saved here for record keeping purpose. No automatic trigger.
This workflow was used to produce the llvmdev_manylinux build on https://anaconda.org/numba/llvmdev/15.0.7/download/win-64/llvmdev-15.0.7-manylinux.tar.bz2
| -DLLVM_ENABLE_ZLIB=OFF ^ | ||
| -DLLVM_ENABLE_ZSTD=OFF ^ |
There was a problem hiding this comment.
This file is a copy of llvmdev/bld.bat with these two lines changed.
swap357
left a comment
swap357
left a comment
There was a problem hiding this comment.
I don't fully understand the implications of recipe changes but workflow looks good to me.
| strategy: | ||
| matrix: | ||
| config: | ||
| - {python: '3.10'} |
There was a problem hiding this comment.
if we're not planning on testing for python versions and just need build, we can simplify and remove matrix here
There was a problem hiding this comment.
Simplifed. New GHA test run: https://github.com/sklam/llvmlite/actions/runs/12258663138/job/34198957127
Fix Windows llvmdev build due to zlib linkage
Conflicts:
conda-recipes/llvmdev_manylinux/meta.yaml
|
Backport (or forward port?) is here: #1114 |
Merge pull request #1108 from sklam/fix/win_wheel
4 participants
(Based on #1104)
Users have reported error using the windows wheel for llvmlite on official CPython distribution (non-Anaconda builds). The error was due to
zlib.dlldependency that is not available on the installed Python.This patch fixes the problem by using
llvmdev_manylinuxrecipe which disabled zlib and zstd.Note: With this patch, all wheel builds use
llvmdev_manylinuxrecipe. The recipe folder should rename tollvmdev_wheelslater. Don't want to do that now which will require changing more buildfarm scripts.In addition, a GHA workflow is added to build the llvmdev for wheels. Example run: https://github.com/sklam/llvmlite/actions/runs/12186143333/job/33993961959