Skip to content

return execute result with operation type and counts - #24

Merged
harksin merged 1 commit into
nudibranches-tech:mainfrom
SG5:feature/return-execute-result
Oct 17, 2025
Merged

return execute result with operation type and counts#24
harksin merged 1 commit into
nudibranches-tech:mainfrom
SG5:feature/return-execute-result

Conversation

@SG5

@SG5 SG5 commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

In current implementation if you try to run DELETE or INSERT via execute, the method doesn't provide any information about number of affected rows.

Because we already have this information in JSON response, we need only to parse it, similar to QueryResult

@SG5
SG5 force-pushed the feature/return-execute-result branch from f725803 to 388e783 Compare October 1, 2025 17:11
@SG5 SG5 changed the title execute returns result with operation type and counts for return execute result with operation type and counts for Oct 1, 2025
@SG5 SG5 changed the title return execute result with operation type and counts for return execute result with operation type and counts Oct 1, 2025
@SG5
SG5 force-pushed the feature/return-execute-result branch from 388e783 to 5d08627 Compare October 1, 2025 17:31
@SG5

SG5 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

@harksin is is possible to review this PR?

@harksin

harksin commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

👋
Thanks for your contribution!
Looks good to me, feel free to merge

@harksin

harksin commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

@SG5 could you rebase please ?
I think our linter is crying due to this.
Once done I will merge your branch and release a new version of the trino-rust-client :)

log response

parse update_count

return result with operation type and counts
@SG5
SG5 force-pushed the feature/return-execute-result branch from 41e82ba to 72046b5 Compare October 9, 2025 22:52
@SG5

SG5 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

@SG5 could you rebase please ?

Just rebased my branch

@SG5

SG5 commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

@harksin bump

@harksin

harksin commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Thanks for the headsup, looking

@harksin
harksin merged commit 1403c6e into nudibranches-tech:main Oct 17, 2025
4 checks passed
@harksin

harksin commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

released in v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants