Skip to content

Conversation

ntno
Copy link
Owner

@ntno ntno commented Aug 18, 2024

point to terminal.css version 0.7.5 (currently at 0.7.4)

resolves #144

Description

the "Terminal for MkDocs" theme is currently behind the terminal.css upstream. this change updates terminal/css/terminal.css to point to version 0.7.5 and makes a few updates to terminal/css/theme.css and one addition to terminal/css/terminal.css to maintain current behavior.

Changes

  • pulls in terminal.css version 0.7.5
  • table styling change:
    • after the header row, the leftmost column will use regular font weight and regular font color instead of strong font weight and secondary font color
  • code block font color css change:
    • added new var --code-font-color to the root CSS configuration and sets the default value to --font-color
    • this is an override to terminal v0.7.5 and maintains current Terminal for MkDocs behavior

Testing

spun up local documentation server in Firefox and spot checked

Checklist

  • I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
  • All active GitHub checks for tests, formatting, and security are passing

@ntno ntno changed the title DRAFT: Upgrade to terminal v0 7 5 DRAFT: Upgrade to terminal v0.7.5 Aug 18, 2024
This was referenced Aug 18, 2024
@ntno
Copy link
Owner Author

ntno commented Aug 18, 2024

table styling change

after the header row, the leftmost column will use regular font weight and regular font color instead of strong font weight and secondary font color

terminal.css v0.7.4

74

terminal.css v0.7.5

75

@ntno
Copy link
Owner Author

ntno commented Aug 18, 2024

overriding change to code font color

terminal.css 0.7.4

regular-font-in-0 7 4

terminal.css 0.7.5

lighter-code-font-in-0 7 5

overriding

in terminal.css

adds new var

    --code-font-color: var(--font-color);

in theme.css

/* use the `code-bg-color` and `code-font-color` for `<code>` blocks */

pre code {
    background-color: var(--code-bg-color);
    color: var(--code-font-color);
}

after override

back-to-regular-font-after-override

@ntno
Copy link
Owner Author

ntno commented Aug 20, 2024

overriding styling change to macro error block

mkdocs-terminal 4.5.0

Screen Shot 2024-08-19 at 10 02 46 PM

proposed change

Screen Shot 2024-08-19 at 10 02 40 PM

after override

Screen Shot 2024-08-19 at 10 19 46 PM

.terminal-mkdocs-macro-error-banner {
    border-style: solid;
    border-width: 1px;
    display: inline-flex;
    align-items: center;
    justify-content: center;
    padding: .65em 2em;
    border-color: var(--error-color);
}

p.terminal-mkdocs-macro-error-banner {
    color: var(--font-color);
}

p.terminal-mkdocs-macro-error-banner>code {
    color: var(--code-font-color);
}

@ntno ntno marked this pull request as ready for review August 20, 2024 02:28
@ntno ntno changed the title DRAFT: Upgrade to terminal v0.7.5 Upgrade to terminal v0.7.5 Aug 20, 2024
@ntno ntno merged commit 3c85784 into main Aug 20, 2024
15 checks passed
@ntno ntno deleted the upgrade-to-terminal-v0-7-5 branch August 20, 2024 02:32
@ntno ntno added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade terminal.css
1 participant