Skip to content

Conversation

ntno
Copy link
Owner

@ntno ntno commented Aug 7, 2024

point to terminal.css version 0.7.4 (currently at 0.7.2)

would make progress on #144

Description

the "Terminal for MkDocs" theme is currently behind the terminal.css upstream. this change updates terminal/css/terminal.css to point to version 0.7.4 and makes a few updates to terminal/css/theme.css to maintain current behavior.

Changes

  • pulls in terminal.css version 0.7.4
    • includes a fix to the <p> font color which should be set to font-color and not global-font-color
  • specifies that <p> inside a <figcaption> should use secondary-color.

Testing

spun up local documentation server in Firefox and spot checked

Checklist

  • I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
  • All active GitHub checks for tests, formatting, and security are passing

@ntno ntno changed the title Upgrade to terminal 0.7.4 DRAFT: Upgrade to terminal 0.7.4 Aug 7, 2024
@ntno
Copy link
Owner Author

ntno commented Aug 7, 2024

upgrade issue - code blocks background color not filling the entire block:

local with 0.7.4

Screen Shot 2024-08-07 at 6 41 10 PM

live with 0.7.2

Screen Shot 2024-08-07 at 6 41 21 PM

fixed with override in theme.css

/* use the `code-bg-color` for `code` blocks */

pre code {
    background-color: var(--code-bg-color);
}

@ntno ntno mentioned this pull request Aug 7, 2024
@ntno ntno mentioned this pull request Aug 14, 2024
2 tasks
@ntno ntno mentioned this pull request Aug 14, 2024
2 tasks
@ntno
Copy link
Owner Author

ntno commented Aug 18, 2024

paragraph tag bug fix

<p></p> color should be font-color not global-font-color

@ntno
Copy link
Owner Author

ntno commented Aug 18, 2024

fix font color in markdown-extended figcaption

when a user takes advantage of the "markdown in html" feature, their caption text is inserted inside of a <p> tag (inside the regular <figcaption> tag). after the fix mentioned above, the <p> tag will use font-color. however it makes more sense for <p> tags inside a <figcaption> to use the secondary color.

fixed in theme.css

/* set figcaption paragraph text to the secondary color.  this occurs when using markdown inside the figcaption */

figure>figcaption>p {
    color: var(--secondary-color);
}

@ntno ntno changed the title DRAFT: Upgrade to terminal 0.7.4 Upgrade to terminal 0.7.4 Aug 18, 2024
@ntno ntno marked this pull request as ready for review August 18, 2024 01:37
@ntno ntno merged commit 37ae27e into main Aug 18, 2024
15 checks passed
@ntno ntno deleted the upgrade-to-terminal-0-7-4 branch August 18, 2024 01:46
@ntno ntno added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant