-
Notifications
You must be signed in to change notification settings - Fork 121
Populate search
user guide
#1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I will automatically update this comment whenever this PR is modified
|
@andypbarrett, a handful of PRs have been merged yesterday and today, so I merged main into this branch. Everything looks good, but pre-commit found a couple of things for you to address: https://results.pre-commit.ci/run/github/399867529/1750949734.9P5fEvIaSeOOcC9gwNe0Pw To reduce the likelihood of pre-commit failing in CI, you can run it locally to identify issues before you push your changes. If you have If you are using a python or conda env, you simply need to activate your environment, then run |
…ss into update-search-user-guide
In progress:
|
Instead of listing out the kwargs, how do you feel about linking to the API documentation for the full list of kwargs? Then we just need to keep one place (docstring) updated with high quality descriptions: earthaccess/earthaccess/api.py Line 95 in e2f4bae
|
@mfisher87 is this what you are thinking of. The list in |
Qu. I would like to include the examples in the docstrings and in the user guides in the testing framework. Is there an accepted way to do this? |
This is a PR to populate the User-Guide Search pages and resolves Issue 852
The page describes
search_datasets
,search_data
andsearch_services
.I've opened it as a Draft PR.
In addition to the User-Guide pages, the docstrings for each of these methods in
earthaccess.api
need to be complete. Issue 345Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1
. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.md
with details about your change in a section titled## Unreleased
. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.md
with details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-support
team in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--1035.org.readthedocs.build/en/1035/