Skip to content

Update for PureScript 0.15 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Update for PureScript 0.15 #37

merged 4 commits into from
Aug 8, 2022

Conversation

thomashoneyman
Copy link
Contributor

Hi @nsaunders! We're using this package in the registry and are upgrading to PureScript 0.15 over there. This PR updates your library for compatibility with PureScript 0.15 packages, and I'll add it to the package sets once merged.

@thomashoneyman thomashoneyman changed the title Trh/0.15 Update for PureScript 0.15 Aug 8, 2022
]
, packages =
./packages.dhall
[ "aff"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies were added because they are used in your source code but not explicitly listed as dependencies. Spago now throws an error if you do that, so I needed to install these.

Also, I've split your Spago file into a file for your library and other files for tests and examples. In the future the package sets will use the Spago file from your repository to determine your dependencies (rather than a separate list in the package-sets repo) so that helps you ship only the dependencies you need to.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific news, thanks @thomashoneyman !

@nsaunders nsaunders merged commit 91ffa9d into nsaunders:master Aug 8, 2022
@nsaunders
Copy link
Owner

Thank you @thomashoneyman! I'm sorry I didn't get to this sooner, but I really appreciate you jumping in to take care of it.

@nsaunders
Copy link
Owner

Hmm, if you happen to notice this failure, don't sweat it... After reviewing spago.example.dhall, it's not obvious to me why the Effect.Console module wouldn't be available; so I'm sure it's just a (GitHub Actions-related) configuration issue on my part. I'll take a closer look later on today.

@thomashoneyman
Copy link
Contributor Author

Ah, perhaps that needs to be spago -x spago.example.dhall run ... so it knows to include those dependencies (you don't use console anywhere in the main library).

@thomashoneyman thomashoneyman deleted the trh/0.15 branch August 8, 2022 17:20
@thomashoneyman
Copy link
Contributor Author

Would you mind pinging me when a new version is published and I can add this to the package sets? Thanks!

@thomashoneyman
Copy link
Contributor Author

@nsaunders Sorry to ping you again, but it looks like that fix to CI worked and this is now eligible for a new release. I'm only commenting because I know it's easy to forget (I forget to publish a new tag all the time!), but you may have other reasons to hold off tagging a new version.

@nsaunders
Copy link
Owner

Ah, perhaps that needs to be spago -x spago.example.dhall run ... so it knows to include those dependencies (you don't use console anywhere in the main library).

Good eye @thomashoneyman! I was looking at the wrong build step.

Would you mind pinging me when a new version is published and I can add this to the package sets? Thanks!

Certainly, I've tagged it as v3.0.0.

Sorry to ping you again, but it looks like that fix to CI worked and this is now eligible for a new release. I'm only commenting because I know it's easy to forget (I forget to publish a new tag all the time!), but you may have other reasons to hold off tagging a new version.

No worries! I'm sorry for the delay...

Thanks again for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants