-
Notifications
You must be signed in to change notification settings - Fork 4
Update for PureScript 0.15 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
] | ||
, packages = | ||
./packages.dhall | ||
[ "aff" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependencies were added because they are used in your source code but not explicitly listed as dependencies. Spago now throws an error if you do that, so I needed to install these.
Also, I've split your Spago file into a file for your library and other files for tests and examples. In the future the package sets will use the Spago file from your repository to determine your dependencies (rather than a separate list in the package-sets repo) so that helps you ship only the dependencies you need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific news, thanks @thomashoneyman !
Thank you @thomashoneyman! I'm sorry I didn't get to this sooner, but I really appreciate you jumping in to take care of it. |
Hmm, if you happen to notice this failure, don't sweat it... After reviewing |
Ah, perhaps that needs to be |
Would you mind pinging me when a new version is published and I can add this to the package sets? Thanks! |
@nsaunders Sorry to ping you again, but it looks like that fix to CI worked and this is now eligible for a new release. I'm only commenting because I know it's easy to forget (I forget to publish a new tag all the time!), but you may have other reasons to hold off tagging a new version. |
Good eye @thomashoneyman! I was looking at the wrong build step.
Certainly, I've tagged it as
No worries! I'm sorry for the delay... Thanks again for all your help! |
Hi @nsaunders! We're using this package in the registry and are upgrading to PureScript 0.15 over there. This PR updates your library for compatibility with PureScript 0.15 packages, and I'll add it to the package sets once merged.