fix(core): treat undefined task parallelism as parallel when scheduling#35736
Merged
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 4d5bc4f
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
May 19, 2026
FrozenPandaz
added a commit
that referenced
this pull request
May 19, 2026
…ng (#35736) ## Current Behavior When deciding whether a task can be scheduled, `TasksSchedule` checked `task.parallelism === true` in two places: - `canBeScheduled` — gating a task against already-running parallel tasks - `canBatchTaskBeScheduled` — gating a task for batch scheduling A task whose `parallelism` is `undefined` failed both checks and was blocked, even though `undefined` is meant to mean "parallel". This was also inconsistent with the running-tasks check, which uses `parallelism === false` — treating `undefined` as parallel-capable. ## Expected Behavior A task with `parallelism === undefined` is treated as parallel in both the regular and batch scheduling checks. Both now use `parallelism !== false`, matching the convention used elsewhere and the documented default. ## Related Issue(s) N/A (cherry picked from commit 05c5589)
FrozenPandaz
added a commit
that referenced
this pull request
May 19, 2026
…ng (#35736) ## Current Behavior When deciding whether a task can be scheduled, `TasksSchedule` checked `task.parallelism === true` in two places: - `canBeScheduled` — gating a task against already-running parallel tasks - `canBatchTaskBeScheduled` — gating a task for batch scheduling A task whose `parallelism` is `undefined` failed both checks and was blocked, even though `undefined` is meant to mean "parallel". This was also inconsistent with the running-tasks check, which uses `parallelism === false` — treating `undefined` as parallel-capable. ## Expected Behavior A task with `parallelism === undefined` is treated as parallel in both the regular and batch scheduling checks. Both now use `parallelism !== false`, matching the convention used elsewhere and the documented default. ## Related Issue(s) N/A (cherry picked from commit 05c5589)
FrozenPandaz
added a commit
that referenced
this pull request
May 19, 2026
…ng (#35736) ## Current Behavior When deciding whether a task can be scheduled, `TasksSchedule` checked `task.parallelism === true` in two places: - `canBeScheduled` — gating a task against already-running parallel tasks - `canBatchTaskBeScheduled` — gating a task for batch scheduling A task whose `parallelism` is `undefined` failed both checks and was blocked, even though `undefined` is meant to mean "parallel". This was also inconsistent with the running-tasks check, which uses `parallelism === false` — treating `undefined` as parallel-capable. ## Expected Behavior A task with `parallelism === undefined` is treated as parallel in both the regular and batch scheduling checks. Both now use `parallelism !== false`, matching the convention used elsewhere and the documented default. ## Related Issue(s) N/A (cherry picked from commit 05c5589)
polygraph-snapshot-app Bot
pushed a commit
that referenced
this pull request
May 20, 2026
…ng (#35736) ## Current Behavior When deciding whether a task can be scheduled, `TasksSchedule` checked `task.parallelism === true` in two places: - `canBeScheduled` — gating a task against already-running parallel tasks - `canBatchTaskBeScheduled` — gating a task for batch scheduling A task whose `parallelism` is `undefined` failed both checks and was blocked, even though `undefined` is meant to mean "parallel". This was also inconsistent with the running-tasks check, which uses `parallelism === false` — treating `undefined` as parallel-capable. ## Expected Behavior A task with `parallelism === undefined` is treated as parallel in both the regular and batch scheduling checks. Both now use `parallelism !== false`, matching the convention used elsewhere and the documented default. ## Related Issue(s) N/A
vrxj81
pushed a commit
to vrxj81/nx
that referenced
this pull request
May 20, 2026
…ng (nrwl#35736) ## Current Behavior When deciding whether a task can be scheduled, `TasksSchedule` checked `task.parallelism === true` in two places: - `canBeScheduled` — gating a task against already-running parallel tasks - `canBatchTaskBeScheduled` — gating a task for batch scheduling A task whose `parallelism` is `undefined` failed both checks and was blocked, even though `undefined` is meant to mean "parallel". This was also inconsistent with the running-tasks check, which uses `parallelism === false` — treating `undefined` as parallel-capable. ## Expected Behavior A task with `parallelism === undefined` is treated as parallel in both the regular and batch scheduling checks. Both now use `parallelism !== false`, matching the convention used elsewhere and the documented default. ## Related Issue(s) N/A
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When deciding whether a task can be scheduled,
TasksSchedulecheckedtask.parallelism === truein two places:canBeScheduled— gating a task against already-running parallel taskscanBatchTaskBeScheduled— gating a task for batch schedulingA task whose
parallelismisundefinedfailed both checks and was blocked, even thoughundefinedis meant to mean "parallel". This was also inconsistent with the running-tasks check, which usesparallelism === false— treatingundefinedas parallel-capable.Expected Behavior
A task with
parallelism === undefinedis treated as parallel in both the regular and batch scheduling checks. Both now useparallelism !== false, matching the convention used elsewhere and the documented default.Related Issue(s)
N/A