-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(bundling): support rollup nested export #33831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
instead of only be taking the name
that allows to generate a rollup config with paths as entry points
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 62353bf
☁️ Nx Cloud last updated this comment at |
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ The fix from Nx Cloud was applied
These changes fix three test failures introduced by the nested export feature. We corrected a typo in type-definitions.ts (file.name → file.fileName), updated all test calls to include the new bundle parameter, and fixed the export path mapping to filter by file extension so ESM and CJS formats don't interfere with each other.
We had verified this fix by re-running rollup:test.
Warning
The suggested diff is too large to display here, but you can view it on Nx Cloud ↗
View interactive diff ↗
This fix was applied by Colum Ferry
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: Coly010 <[email protected]>
Current Behavior
nested additionalEntryPoints are all moved to the root or the library
Expected Behavior
additionalEntryPoints path should be kept when bundling a library
Related Issue(s)
Fixes #33789