Skip to content

Conversation

@Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 12, 2025

Current Behavior

nested additionalEntryPoints are all moved to the root or the library

Expected Behavior

additionalEntryPoints path should be kept when bundling a library

Related Issue(s)

Fixes #33789

@Coly010 Coly010 requested a review from a team as a code owner December 12, 2025 10:52
@Coly010 Coly010 requested a review from jaysoo December 12, 2025 10:52
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 62353bf
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/693c010a6eef12000822244a
😎 Deploy Preview https://deploy-preview-33831--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Dec 12, 2025 11:53am

@Coly010 Coly010 changed the title Feat support rollup nested export feat(bundling): support rollup nested export Dec 12, 2025
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Dec 12, 2025

View your CI Pipeline Execution ↗ for commit 62353bf

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 4m 45s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 24s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-12 14:19:36 UTC

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The fix from Nx Cloud was applied

These changes fix three test failures introduced by the nested export feature. We corrected a typo in type-definitions.ts (file.name → file.fileName), updated all test calls to include the new bundle parameter, and fixed the export path mapping to filter by file extension so ESM and CJS formats don't interfere with each other.

We had verified this fix by re-running rollup:test.

Warning

The suggested diff is too large to display here, but you can view it on Nx Cloud ↗


Revert fix via Nx Cloud  

View interactive diff ↗
This fix was applied by Colum Ferry

🎓 Learn more about Self-Healing CI on nx.dev

@Coly010 Coly010 marked this pull request as draft December 12, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants