fix(native): correct glob pattern expansion for ZeroOrOne groups #31857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,build,e2e,e2e-c... |
❌ Failed | 1h 40m 12s | View ↗ |
nx run-many -t check-imports check-commit check... |
✅ Succeeded | 1m 38s | View ↗ |
nx-cloud record -- nx-cloud conformance:check |
✅ Succeeded | 2s | View ↗ |
nx-cloud record -- nx sync:check |
✅ Succeeded | 3s | View ↗ |
nx-cloud record -- nx format:check |
✅ Succeeded | 3s | View ↗ |
nx documentation |
✅ Succeeded | 4m 28s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-07-21 20:35:02 UTC
|
@claude add a unit test to confirm the behavioral changes here |
|
Claude finished @AgentEnder's task —— View job Todo List:
SummaryI've successfully added comprehensive unit tests for the ZeroOrOne glob pattern behavior to confirm the fix for issue #26880. Here's what was accomplished: Test Added: Created
Commits Made:
Analysis: The fix correctly separates The unit tests verify that this behavioral change is working correctly and will prevent regression in the future. |
The Rust hasher was incorrectly expanding glob patterns with optional groups like `__test?(s)__` because ZeroOrOne and ZeroOrMore patterns were combined in the same match arm but require different handling. The issue was that ZeroOrOne patterns were using `*` as a fallback when not matched, which caused patterns like `__test?(s)__` to incorrectly expand to `*__` instead of `__test__` when the optional `s` was not matched. This fix separates the ZeroOrOne and ZeroOrMore cases, ensuring that ZeroOrOne patterns preserve the existing pattern when the optional group is not matched. Fixes #26880 Co-authored-by: Craigory Coppola <[email protected]> test(native): add unit tests for ZeroOrOne glob pattern behavior Add comprehensive unit tests for ZeroOrOne pattern expansion to verify the fix for issue #26880 where patterns like `__test?(s)__` were incorrectly expanding to `*__` instead of `__test__`. The tests cover: - Simple ZeroOrOne pattern: `__test?(s)__` - Pattern with prefix: `prefix?(suffix)` - Pattern in middle: `start?(middle)end` - Multiple ZeroOrOne patterns: `?(a)test?(b)` Co-authored-by: Craigory Coppola <[email protected]> style(native): format Rust code with rustfmt Apply rustfmt formatting to the glob_transform.rs file to ensure consistent code style after adding the new unit tests. Co-authored-by: Craigory Coppola <[email protected]>
AgentEnder
force-pushed
the
claude/issue-26880-20250708_142926
branch
from
ab621cf to
185ba35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust hasher was incorrectly expanding glob patterns with optional groups like
__test?(s)__because ZeroOrOne and ZeroOrMore patterns were combined in the same match arm but require different handling.The issue was that ZeroOrOne patterns were using
*as a fallback when not matched, which caused patterns like__test?(s)__to incorrectly expand to*__instead of__test__when the optionalswas not matched.This fix separates the ZeroOrOne and ZeroOrMore cases, ensuring that ZeroOrOne patterns preserve the existing pattern when the optional group is not matched.
Fixes #26880
Generated with Claude Code