feat(core): http cache use native cert store #31854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It enable hability to use SSL_CERT_FILE and SSL_CERT_DIR variables to use custom certificate with self hosted remote cache
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It enable hability to use SSL_CERT_FILE and SSL_CERT_DIR variables to use custom certificate with self hosted remote cache
Current Behavior
Today, We can only disable all SSL validation with NODE_TLS_REJECT_UNAUTHORIZED.
It disable every security and juste skip SSL validation.
It's the same variable of node it has so much security side effect
Expected Behavior
With this PR, we can just use native certificate authorities or standard OpenSSL variables SSL_CERT_FILE SSL_CERT_DIR.
So we can use self hosted NX cache with security and avoid risk of attacks.
Related Issue(s)