feat(core): allow {args} to be fully interpolated in run-commands #31824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 4a36a9c
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Pull Request Overview
This PR adds full {args} interpolation support to the run-commands executor, refactors the existing argument-forwarding logic into helper functions, and updates tests to cover the new behavior.
- Introduce a
{args}placeholder branch ininterpolateArgsIntoCommand - Extract argument-building logic into
unknownOptionsToArgsArrayandunparsedOptionsToArgsArray - Refactor
readFilein tests and add a test for{args}interpolation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/nx/src/executors/run-commands/run-commands.impl.ts | Add {args} interpolation, refactor forwardAllArgs logic, and introduce two helper functions |
| packages/nx/src/executors/run-commands/run-commands.impl.spec.ts | Extend readFile helper and add a new test case verifying {args} interpolation |
Comments suppressed due to low confidence (1)
packages/nx/src/executors/run-commands/run-commands.impl.spec.ts:231
- The new test covers interpolation of
__unparsed__args, but doesn’t verify behavior whenopts.argsis also provided. Adding a test that includes both__unparsed__andargswould ensure full coverage of the{args}branch.
it('should interpolate {args} to contain all provided args', async () => {
FrozenPandaz
requested changes
Jul 4, 2025
FrozenPandaz
approved these changes
Jul 15, 2025
ndcunningham
pushed a commit
that referenced
this pull request
Jul 15, 2025
…1824) ## Current Behavior Currently, there is no way for a target using `run-commands` to define where in the command args are attached. This is problematic in some tooling cases where args positional location matters ## Expected Behavior Placing `{args}` into the command should allow for interpolation of any and all args provided. Therefore commands can be written such as `docker run {args} imageRef`
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 15, 2025
…1824) ## Current Behavior Currently, there is no way for a target using `run-commands` to define where in the command args are attached. This is problematic in some tooling cases where args positional location matters ## Expected Behavior Placing `{args}` into the command should allow for interpolation of any and all args provided. Therefore commands can be written such as `docker run {args} imageRef` (cherry picked from commit 434cf45)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, there is no way for a target using
run-commandsto define where in the command args are attached.This is problematic in some tooling cases where args positional location matters
Expected Behavior
Placing
{args}into the command should allow for interpolation of any and all args provided.Therefore commands can be written such as
docker run {args} imageRef