Skip to content

Conversation

nordic-mik7
Copy link
Contributor

Thic PR introduces support for ed25519 signature verification when CONFIG_NCS_BOOT_SIGNATURE_USING_ITS is set (through PSA API).

@ahasztag ahasztag requested a review from de-nordic August 25, 2025 09:15
@ahasztag ahasztag requested review from nvlsianpu and nordicjm August 29, 2025 11:49
Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
Rename the kmu_key_ids to key_ids or whatever common name there can be made, and name the both lists the name, just choose one by selected secure storage.
Reduce all the changes, in the ifdef from, by moving all required compile time logic into one place, above all the usage cases.
Add common cpp identifiers for key count and secure storage usage.

Thic commit introduces support for ed25519 signature verification when
CONFIG_NCS_BOOT_SIGNATURE_USING_ITS is set (through PSA API).

Signed-off-by: Michal Kozikowski <[email protected]>
@ahasztag ahasztag force-pushed the dev/ed25519_ITS_support branch from d01e51a to c911069 Compare September 3, 2025 09:27
Copy link

sonarqubecloud bot commented Sep 3, 2025

@ahasztag
Copy link
Contributor

ahasztag commented Sep 3, 2025

No. Rename the kmu_key_ids to key_ids or whatever common name there can be made, and name the both lists the name, just choose one by selected secure storage. Reduce all the changes, in the ifdef from, by moving all required compile time logic into one place, above all the usage cases. Add common cpp identifiers for key count and secure storage usage.

Michał is on vacation so I will continue work on this PR. Changed as you've suggested.

@ahasztag ahasztag requested a review from de-nordic September 3, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants