-
Notifications
You must be signed in to change notification settings - Fork 233
zephyr: boards: remove redundant multithreading configuration #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nordic-mik7
wants to merge
4
commits into
nrfconnect:main
Choose a base branch
from
nordic-mik7:dev/remove_reduntant_multithreading_downstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
zephyr: boards: remove redundant multithreading configuration #464
nordic-mik7
wants to merge
4
commits into
nrfconnect:main
from
nordic-mik7:dev/remove_reduntant_multithreading_downstream
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration Remove configs that enable multithreading just because of SPI/QSPI use. Currently, nrf drivers do not depend on multithreading, so it is not needed and this change can save memory usage. Upstream PR #: 2375 Signed-off-by: Michal Kozikowski <[email protected]>
tomchy
approved these changes
Jul 7, 2025
ahasztag
approved these changes
Jul 7, 2025
nordicjm
requested changes
Jul 8, 2025
@@ -1,4 +1,3 @@ | |||
CONFIG_MULTITHREADING=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
nordicjm
reviewed
Jul 8, 2025
nrf-squash! [nrf noup] boot/zephyr: add nrf54l15dk ext flash configs This is a follow up to the upstream PR #2375 and it removes multithreading configs in 'noup' changes that were only here because of SPI/QSPI use. Signed-off-by: Michal Kozikowski <[email protected]>
nrf-squash! [nrf noup] boards: Thingy:91 X release config This is a follow up to the upstream PR #2375 and it removes multithreading configs in 'noup' changes that were only here because of SPI/QSPI use. Signed-off-by: Michal Kozikowski <[email protected]>
nrf-squash! [nrf noup] boot: nrf53-specific customizations This is a follow up to the upstream PR #2375 and it removes multithreading configs in 'noup' changes that were only here because of SPI/QSPI use. Signed-off-by: Michal Kozikowski <[email protected]>
68b75c2
to
d646a3b
Compare
|
nordicjm
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the upstream PR #2375 and it removes
multithreading configs in 'noup' changes that were only here because
of SPI/QSPI use.