Skip to content

forward signals to children #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

forward signals to children #9

wants to merge 6 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Oct 26, 2020

this change adds handlers to ensure that signals are forwarded to child processes appropriately. handlers are not added until a process exists that should be monitored, and are removed as soon as all children have exited, carrying the first non-falsey exit code received from a child.

for: npm/cli#1947

Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style nits, mostly. Only substantive bit is a question about how we handle multiple signals, and child process exiting (or not exiting) as a result of those signals. (The npm v6 way seems like the worst of both worlds.)

@isaacs isaacs closed this in 13e0b40 Oct 27, 2020
@lukekarrys lukekarrys deleted the nlf/forward-signals branch February 23, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants