Conversation
nlf
previously approved these changes
Apr 12, 2023
This is useful when generating a file which is not intended to be used on the same platform as the current one. Most embedded system today use the DOS/Windows format only.
nlf
approved these changes
Apr 12, 2023
Merged
Creskendoll
reviewed
May 4, 2023
Contributor
Creskendoll
left a comment
Creskendoll
left a comment
There was a problem hiding this comment.
Hello, wanted to let you know that this change is not compatible with browser environments.
I'm aware that the library is meant to be used with Node, but the implementation should be platform-agnostic.
I'll create a PR that addresses this.
Thank you for your work 🙏
| opt.whitespace = opt.whitespace === true | ||
| opt.newline = opt.newline === true | ||
| /* istanbul ignore next */ | ||
| opt.platform = opt.platform || process?.platform |
Contributor
There was a problem hiding this comment.
Trying to access process in a browser environment fails.
The availability of the value needs to be checked with typeof process === 'undefined'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase and cleanup of #64
Author: @asnowfix