Skip to content

Use npm install for all CI jobs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use npm install for all CI jobs #37

wants to merge 1 commit into from

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Aug 15, 2019

This PR fixes the failing CI jobs.

@isaacs
Copy link
Contributor

isaacs commented Aug 15, 2019

This should be unnecessary since #38 is landed, yes?

@isaacs isaacs closed this Aug 15, 2019
@DanielRuf
Copy link
Contributor Author

Well the general issue is that Travis CI uses npm ci starting at specific NodeJS versions so some builds may use different dependencies (depending on if ci or install was used).

Generally it should be set in the Travis CI config to ensure consistent jobs.

@isaacs
Copy link
Contributor

isaacs commented Aug 16, 2019

CI is passing now, so I think we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants