-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(powershell): use Invoke-Expression to pass args #8267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
755c75a
fix(powershell): use Invoke-Expression to pass args
alexsch01 5981a1b
`$MyInvocation.Statement` is undefined in Windows PowerShell
alexsch01 d37f8f9
`windows-shims.js`: cover passing regular and named parameters to scr…
alexsch01 7a931ed
add tests for comma-separated values
alexsch01 6ac5541
remove test that doesn't work in command prompt
alexsch01 230fcd8
add npx tests
alexsch01 d18d75e
correct test
alexsch01 f3ff347
small change
alexsch01 ece490b
Update windows-shims.js
alexsch01 f446d38
Update windows-shims.js
alexsch01 a4077f5
make less strict
alexsch01 9f8bb56
oops
alexsch01 fee22f1
`npm.ps1` fix multiple commands
alexsch01 3a4bde2
`npx.ps1` fix multiple commands
alexsch01 16ee512
Update windows-shims.js
alexsch01 d8bd5a2
formatting change
alexsch01 58b9d55
fix typos
alexsch01 1526dfe
replace tests
alexsch01 860481e
Update windows-shims.js
alexsch01 50e77f7
Update windows-shims.js
alexsch01 c3f8c94
skip tests that can't pass with cygwin
alexsch01 77e5af2
more consistent
alexsch01 ce0bf2b
more consistent
alexsch01 bd2cd77
revert bad commits
alexsch01 cc9e57a
add back consistency commits, add check for Windows PowerShell but do…
alexsch01 1bfbd78
complete change
alexsch01 360b090
also for npx.ps1
alexsch01 668d40d
oop
alexsch01 72c9fdd
formatting
alexsch01 fb49f5b
remove normalize part
alexsch01 2d03217
check value of `$MyInvocation.OffsetInLine`
alexsch01 204a228
finally get it to pass
alexsch01 4befbeb
add `powershell.exe` test, have default case for PS1 scripts, revert …
alexsch01 8502ce0
Merge branch 'npm:latest' into latest
alexsch01 60161d2
make simpler
alexsch01 622f7fe
oops
alexsch01 09f002d
properly quote `$NODE_EXE` and `$NPM_CLI_JS`/`$NPX_CLI_JS` with Invok…
alexsch01 cd4eab7
use reflection to get the full powershell command
alexsch01 a128038
use `$MyInvocation.Statement` if exists already
alexsch01 d74a744
combine tests
alexsch01 8235520
fix test
alexsch01 59e56c0
make simpler
alexsch01 81f2426
single exit for ps1 bin files, single-quote test
alexsch01 7386bde
Merge branch 'npm:latest' into latest
alexsch01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.