-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Closed
Labels
💎 Free Internet Points 💎similar to "Good First issue" - although more impactfulsimilar to "Good First issue" - although more impactfulEnhancementnew feature or improvementnew feature or improvementGood First Issuegood issue or PR for newcomersgood issue or PR for newcomerssemver:patchsemver patch level for changessemver patch level for changes
Description
Hi, while I was reading the code I found that there are variables that are never used:
In the file ls.js the function getChildren do a filter by the selected workspaces an other by edges types if shouldSkipChildren is false.
The function "filterByEdgesTypes" filter debs by type and allows for: npm ls [--dev, --prod, --link, etc.]
But the variables node and tree are never used by this function.
Also, the npx-cli.js file have problems related to ESLint style.
In order to prevent future errors and have a more clear code, if there is no problem, I will submit a pull request with the changes I did :)
darcyclarke
Metadata
Metadata
Assignees
Labels
💎 Free Internet Points 💎similar to "Good First issue" - although more impactfulsimilar to "Good First issue" - although more impactfulEnhancementnew feature or improvementnew feature or improvementGood First Issuegood issue or PR for newcomersgood issue or PR for newcomerssemver:patchsemver patch level for changessemver patch level for changes