-
Notifications
You must be signed in to change notification settings - Fork 1
chore: improve name for future base exception #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated the C# code generation configuration in .speakeasy/gen.yaml by changing baseErrorName from NovuError to BaseException. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.speakeasy/gen.yaml (2)
27-27
: Consider a product-scoped base exception name (e.g., NovuException) instead of the generic “BaseException”.“BaseException” is very generic and can be confused with Python’s root exception. In .NET ecosystems it’s conventional to brand the base exception (e.g., NovuException or NovuSdkException) to avoid ambiguity and improve discoverability. This also reduces the chance of type-name collisions across libraries.
Suggested change:
- baseErrorName: BaseException + baseErrorName: NovuException
27-27
: Optional: Document the upcoming change in RELEASE/CHANGELOG to minimize surprises.Even if this is a no-op today, a future swap-in of a differently named base type can be perceived as a breaking change by users who reference exception types directly. A short note in the changelog or migration guide will help set expectations.
Happy to draft the release note snippet when you’re ready.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.speakeasy/gen.yaml
(1 hunks)
🔇 Additional comments (1)
.speakeasy/gen.yaml (1)
27-27
: ConfirmbaseErrorName
is a no-op today and prepare for future inheritance
- I ran a repository-wide search for
NovuError
,BaseException
,NovuException
,APIException
,baseErrorName
, anddefaultErrorName
.
• There are zero mentions ofBaseException
(or the oldNovuError
/NovuException
) in code or docs.
• All thrown errors areNovu.Models.Errors.APIException
, defined insrc/Novu/Models/Errors/APIException.cs
.- As expected, adding
baseErrorName: BaseException
in.speakeasy/gen.yaml
does not change the existing SDK today.- Once the Speakeasy C# generator’s feature flag rolls out, it should generate exceptions (e.g.
APIException
) that inherit from your newBaseException
per generator semantics.Please verify with the Speakeasy C# generator documentation or a sample generation run that, under the feature flag,
APIException : BaseException
(and other exceptions likewise) is produced.
In an upcoming release, all SDK exceptions will inherit from a base exception to ease error handling. Given that the default exception is currently named
APIException
, this PR aims at improving naming consistency by editing thebaseErrorName
configuration parameter. Note this configuration change is a no-op for now and will only have effect once the new Error handling feature is released.Summary by CodeRabbit