Skip to content

Conversation

@zr-msft
Copy link
Contributor

@zr-msft zr-msft commented Apr 19, 2023

Added link to official docs to make it easier to find and navigate to when users come across this project and updated link to ACR docs.

@codecov-commenter
Copy link

Codecov Report

Merging #636 (e91ab8a) into main (65b0a4c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   33.95%   33.95%           
=======================================
  Files          32       32           
  Lines        1882     1882           
=======================================
  Hits          639      639           
  Misses       1221     1221           
  Partials       22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

FeynmanZhou
FeynmanZhou previously approved these changes Apr 20, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title Add link to README to docs for clarity doc: add link to README to docs for clarity Apr 20, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but IANAM
@priteshbandi Looking for your review

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 4cefaae into notaryproject:main May 19, 2023
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Added link to official docs to make it easier to find and navigate to
when users come across this project and updated link to ACR docs.

Signed-off-by: Zach Rhoads <[email protected]>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Added link to official docs to make it easier to find and navigate to
when users come across this project and updated link to ACR docs.

Signed-off-by: Zach Rhoads <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants