Skip to content

Conversation

@nowyDEV
Copy link
Contributor

@nowyDEV nowyDEV commented Dec 18, 2023

What

  • Nested ternaries are ok, especially when they are properly formatted (prettier should improve it soon)

Compatibility

  • Does this change maintain backward compatibility?

@nowyDEV nowyDEV added the enhancement New feature or request label Dec 18, 2023
@nowyDEV nowyDEV requested a review from a team as a code owner December 18, 2023 20:59
@nowyDEV nowyDEV self-assigned this Dec 18, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@nowyDEV nowyDEV merged commit 15fe52e into master Dec 18, 2023
@nowyDEV nowyDEV deleted the update-common-config branch December 18, 2023 21:00
@nowyDEV
Copy link
Contributor Author

nowyDEV commented Dec 18, 2023

🎉 This is included in version v9.1.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant