Closed
Conversation
supplement macro
Collaborator
|
@No-needto-recall , thanks for the suggestions, I'll (likely) implement and document a default-enabled configuration flag for it. |
martinmoene
added a commit
that referenced
this pull request
Aug 5, 2024
Author
Thank you very much for incorporating my suggestions and updating the code! I am delighted to see my contribution having a positive impact on the project. I am more than willing to continue contributing wherever help or improvements are needed in the future. Now that the objective of this PR has been achieved, I will proceed to close it. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Add WIN32_LEAN_AND_MEAN Macro to Resolve Naming Conflicts
Body:
Problem Description
While compiling the Cesium project, I encountered naming conflicts due to the absence of the WIN32_LEAN_AND_MEAN macro definition. This macro directs Windows headers to include only the essential parts, helping to avoid potential naming conflicts and possibly reducing compilation time.
Proposed Change
I suggest adding the WIN32_LEAN_AND_MEAN macro definition to the project to address and prevent potential naming conflicts and to optimize the compilation process. To maintain flexibility and backward compatibility, I propose making this macro a configurable compile option, allowing users to enable or disable it based on their needs.
Implementation Details
Add the following code to the project's main header file or an appropriate configuration file:
Additionally, document how to enable or disable this macro depending on the user's compilation environment.
Expected Impact
Integrating this macro should reduce potential naming conflicts caused by the full inclusion of the Windows API and might slightly improve compilation efficiency. This change is expected to have no impact on existing functionalities and has been confirmed not to introduce new issues through CI testing.
Request for Feedback
I invite feedback from other community members and project maintainers, especially regarding the compatibility and effectiveness of this change in different environments. Any suggestions on how to better integrate this change are highly welcome.
Conclusion
Thank you for your time and consideration! I look forward to your feedback and hope that this change will bring practical benefits to the project.