Skip to content

Update actions/checkout in GitHub Actions to v4#63

Merged
martinmoene merged 2 commits intononstd-lite:masterfrom
striezel-stash:actions-checkout-v4
Jan 15, 2024
Merged

Update actions/checkout in GitHub Actions to v4#63
martinmoene merged 2 commits intononstd-lite:masterfrom
striezel-stash:actions-checkout-v4

Conversation

@striezel
Copy link
Contributor

This updates actions/checkout in the GitHub Actions workflows to v4, it's current version.

Changelog:

v4.1.0

  • Add support for partial checkout filters

v4.0.0

  • Support fetching without the --progress option
  • Update to node20

@striezel
Copy link
Contributor Author

The logs of the failed clang jobs contain (among others) the following error messages:

In file included from /home/runner/work/expected-lite/expected-lite/test/expected-main.t.cpp:8:
In file included from /home/runner/work/expected-lite/expected-lite/test/./expected-main.t.hpp:45:
In file included from /home/runner/work/expected-lite/expected-lite/test/lest/lest.hpp:13:
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: error: call to consteval function 'std::chrono::hh_mm_ss::_S_fractional_width' is not a constant expression
        static constexpr unsigned fractional_width = {_S_fractional_width()};
                                                      ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: note: undefined function '_S_fractional_width' cannot be used in a constant expression
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2275:2: note: declared here
        _S_fractional_width()
        ^
1 error generated.

I am not completely sure, but it may be related to an open issue with the GitHub runner images: actions/runner-images#8659 As far as I understand it (and I may be wrong here), Clang uses libstdc++, the C++ standard library implementation of GCC, and those particular versions seem to be incompatible with each other. So a possible workaround may be to try different versions of libstdc++.

See <actions/runner-images#8659> for
more information. Currently, Clang and libstdc++ provided by the
GitHub Actions runner image are incompatible. The basic idea of
this workaround is to remove the incompatible g++ 13 and its C++
standard library and replace that with a compatible version of
libstdc++.
@striezel
Copy link
Contributor Author

I've just added a workaround for the above issue in commit 97feee7. Let's see whether this works.

@striezel
Copy link
Contributor Author

It seems to work, both clang build jobs are green. :)

@martinmoene martinmoene merged commit 3634b0a into nonstd-lite:master Jan 15, 2024
@striezel striezel deleted the actions-checkout-v4 branch January 16, 2024 23:31
martinmoene added a commit that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants