Skip to content

On dev branch, fix method name encoder.fromBase64 in example code #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2020
Merged

On dev branch, fix method name encoder.fromBase64 in example code #3246

merged 1 commit into from
Aug 22, 2020

Conversation

mk-pmb
Copy link
Contributor

@mk-pmb mk-pmb commented Aug 21, 2020

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

Obviously the example code in the fromBase64 section should demonstrate the fromBase64 method.

@mk-pmb mk-pmb force-pushed the docs-fix-encoder-frombase64-dev branch 2 times, most recently from 51056a3 to a04a469 Compare August 21, 2020 21:14
@marcelstoer marcelstoer added this to the Next release milestone Aug 22, 2020
@marcelstoer marcelstoer merged commit 1f386e9 into nodemcu:dev Aug 22, 2020
vsky279 pushed a commit to vsky279/nodemcu-firmware that referenced this pull request Nov 21, 2020
@mk-pmb @vsky279
Fix method name encoder.fromBase64 in example code (nodemcu#3246)
bc3c8aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix documentation
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@mk-pmb @marcelstoer