-
Notifications
You must be signed in to change notification settings - Fork 3.1k
First phase of number to integer conversion #3221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These all look fine. |
We've also missed a few other modules:
|
@pjsg, I've gone through the rest of the updates and done another push. There's a conflict in |
Conflicts: app/modules/sjson.c
I've resolved the conflict in sjson.c -- it builds with both 5.1 and 5.3 versions. But no testing beyond that. I'll merge this into my iot device build and give it a whirl. |
Thanks Philip. Like you, all I did was a full Travis clean compile on both versions. I don't have the H/W to test a lot of these, but the changes are mainly number to integer swaps when the C-side variables are |
@nwf Nathaniel, perhaps you could do a review of these and merge them into |
Just winding you up 😉. Make the change. |
Phil's last change fixed @nwf 's niggle so I reckon that we are good to go on this. |
Fixes #3214, #3215.
dev
branch rather than formaster
.docs/*
.Changing calls to
checknumber
andpushnumber
to becheckinteger
andpushinteger
as this is (nearly always) the right thing to do.