test: absorb h2 stream timeout resets#5383
Conversation
Signed-off-by: marko1olo <barsukdana@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5383 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.01%
==========================================
Files 110 110
Lines 36752 36752
==========================================
+ Hits 34274 34278 +4
+ Misses 2478 2474 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Good call closing the RetryAgent inside the test body and awaiting server close from cleanup. Those late ECONNRESET errors from timed-out h2 streams are expected — swallowing them in the cleanup hook is the right approach since the test intentionally lets every stream time out. |
|
@AliMahmoudDev @marko1olo it seems this is part of a Bot/automation campaign. Slow down and review all changes manually. Purely automated contributions are not welcomed. |
|
fair point @mcollina — i'll slow down on the reviews and make sure to test changes manually before commenting. no intention to come across as automated. |
Summary
issue-5137timeout regression test.RetryAgentinside the test body so teardown happens before node:test reports late asynchronous activity.Why
A macOS Node 25 CI run reported
test/issue-5137.jsgenerating asynchronous activity after the test ended withError: read ECONNRESET. The test intentionally lets every HTTP/2 stream time out, so client-side resets are expected teardown noise rather than the regression under test.Test
node --test test\issue-5137.js1..5 | ForEach-Object { node --test test\issue-5137.js }npx eslint --no-cache test\issue-5137.jsgit diff --checkAI-assisted contribution: implementation and verification were performed with OpenAI Codex under my direction.